-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1896: Thoroughly test ItemSelectionInputContainsAtLeastOneOfRuleClassifier #2073
Fixes #1896: Thoroughly test ItemSelectionInputContainsAtLeastOneOfRuleClassifier #2073
Conversation
Will be fixing the lint test errors, could I get some leads on how to fix the Roboelectric tests? They are giving the following outputs:
|
@Arjupta @prayutsu would you like to help the contributor here with few initial thoughts on this. @navneetsaluja Check our wiki guide here for ktlint issues - https://github.com/oppia/oppia-android/wiki/Ktlint-Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will get your failing lint checks done
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
Have you tried this after connecting to internet? |
@anandwana001 Thank you!
I'm not sure what you mean. All these tests were done on Github while pushing (here). Other than that, my local instance is always connected to the internet. |
I think you should run these tests once again. So just make a commit after correcting the lint error, it will automatically trigger the tests |
Hi @navneetsaluja |
These tests are giving this error because these are not relevant to this particular classifier, in this test we want to test if the |
@navneetsaluja You can do one more thing, you can add keywords |
@prayutsu @Arjupta PTAL, checks passed, thanks. |
Changes I mentioned are done correctly. LGTM Thanks @navneetsaluja |
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Show resolved
Hide resolved
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Show resolved
Hide resolved
@navneetsaluja I think variable names are fine, but I am not sure about the test case names, maybe @anandwana001 can suggest some good name. |
@navneetsaluja It would be more close to our conventional title for the PRs if you add a colon after |
@prayutsu I see, will take care of it in future PRs. Thanks. |
@prayutsu new commit, PTAL :) |
@anandwana001 i think only the author of PR and people with write access can resolve them, as I am unable to find the resolve conversation button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @navneetsaluja
nit change added
...rules/itemselectioninput/ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
@/anandwana001(Not pinging because you've already been assigned) UPDATE: Checks passed now, I didn't change anything. When I wrote the original comment it was displaying the error above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @navneetsaluja
Before the merge, could you please run all the test cases and put a screenshot in the description showing all tests are passing?
@rt4914 Adding you for further merge.
@anandwana001 Added screenshot! |
Explanation
Fixes #1896
Tests for lowercase and uppercase inputs. (More test suggestions would be appreciated, this is just to ensure my skeleton is fine.)
(Any help on how to test that these test files are working properly would be appreciated as well)
Proof
Checklist